qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
43 stars 14 forks source link

Docformatter #714

Closed alecandido closed 9 months ago

alecandido commented 9 months ago

A further step into code standardization.

docformatter is provided by PyCQA (same organization of isort and flake8)

I took the chance to remove the previous custom setting for Black as well.

Checklist:

codecov[bot] commented 9 months ago

Codecov Report

Attention: 277 lines in your changes are missing coverage. Please review.

Comparison is base (47310f2) 62.09% compared to head (2482f3e) 62.09%.

Files Patch % Lines
src/qibolab/instruments/qblox/cluster_qrm_rf.py 0.00% 55 Missing :warning:
src/qibolab/instruments/qblox/cluster_qcm_bb.py 0.00% 51 Missing :warning:
src/qibolab/instruments/qblox/cluster_qcm_rf.py 0.00% 36 Missing :warning:
src/qibolab/instruments/qblox/port.py 4.54% 21 Missing :warning:
src/qibolab/instruments/qblox/controller.py 10.00% 18 Missing :warning:
src/qibolab/pulses.py 72.22% 15 Missing :warning:
src/qibolab/instruments/zhinst.py 81.35% 11 Missing :warning:
src/qibolab/instruments/qblox/q1asm.py 18.18% 9 Missing :warning:
src/qibolab/instruments/erasynth.py 0.00% 8 Missing :warning:
src/qibolab/instruments/icarusq.py 0.00% 8 Missing :warning:
... and 15 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #714 +/- ## ======================================= Coverage 62.09% 62.09% ======================================= Files 49 49 Lines 6854 6854 ======================================= Hits 4256 4256 Misses 2598 2598 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/714/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/714/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `62.09% <45.57%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stavros11 commented 9 months ago

Thanks @AleCandido, I agree with the changes. I see that pre-commit failed in the CI though. Maybe we need to apply the fixes caused by the change in black locally?