qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
43 stars 14 forks source link

Sweeping offset values instead of flux pulses on Zurich #719

Closed GabrielePalazzo closed 7 months ago

GabrielePalazzo commented 9 months ago

Checklist:

codecov[bot] commented 8 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8dc5c5d) 62.58% compared to head (ceaec95) 62.46%. Report is 254 commits behind head on main.

Files Patch % Lines
src/qibolab/instruments/zhinst.py 78.57% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #719 +/- ## ========================================== - Coverage 62.58% 62.46% -0.12% ========================================== Files 48 48 Lines 6644 6658 +14 ========================================== + Hits 4158 4159 +1 - Misses 2486 2499 +13 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/719/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/719/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `62.46% <78.57%> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jacfomg commented 7 months ago

@GabrielePalazzo I was trying it for the resonator flux dependence and the data was different from the expected.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (13bdcb4) 64.03% compared to head (de9e2f9) 63.89%.

Files Patch % Lines
src/qibolab/instruments/zhinst.py 78.57% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #719 +/- ## ========================================== - Coverage 64.03% 63.89% -0.14% ========================================== Files 49 49 Lines 5778 5792 +14 ========================================== + Hits 3700 3701 +1 - Misses 2078 2091 +13 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/719/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/719/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `63.89% <78.57%> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.