Closed GabrielePalazzo closed 9 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
56bf837
) 62.58% compared to head (545a865
) 62.57%. Report is 79 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/qibolab/instruments/zhinst.py | 94.33% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In general, there is a lot of duplication of code in the ZI driver, and this is another example of it. E.g. similar logic for handling subsequences and delays between pulses exists for qubit drive and qubit flux as well. This is not your fault and should not be addressed in this PR. Everything else is done like this in the driver so to fix the bug you are kind of forced to do it like this as well, because otherwise you will need to rewrite half of the driver :D. I just wanted to point this out and emphasize that we need to address it ASAP. I will be taking care of that, so no action point for you, just FYI.
Closes #722.
Checklist: