Closed PiergiorgioButtarini closed 4 months ago
Attention: 109 lines
in your changes are missing coverage. Please review.
Comparison is base (
e11f5c8
) 64.00% compared to head (c72f618
) 64.45%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is also outdated wrt main
. If you know that is working, and the review is just the routine check, please merge/rebase.
Otherwise, make sure that the branch is updated, and you'd like to merge (I'm asking just because it's not very recent).
@alecandido I put us as reviewers because I think in the last Qibo meeting @PiergiorgioButtarini said that this is ready to merge and overall is reducing the lines of code so would be good to merge. But indeed let's wait for him to fix the conflict and let us know.
Yes, I got your point, but there are a few PRs that are aging a bit in Qibolab, so we should be slightly more careful when merging.
Attention: Patch coverage is 26.11940%
with 99 lines
in your changes are missing coverage. Please review.
Project coverage is 64.54%. Comparing base (
2d48d2a
) to head (e24294a
). Report is 85 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Superseded by #868 and the subsequent rewriting
This PR follows the philosophy established in https://github.com/qiboteam/qibolab/pull/686 where common properties between the three diferent Qblox modules are defined directly in the class
ClusterModule
(inmodule.py
) and then are inherited by all of them.TODO:
Test on hardware.
Checklist: