Closed stavros11 closed 8 months ago
Attention: 88 lines
in your changes are missing coverage. Please review.
Comparison is base (
90b5775
) 63.88% compared to head (3cf00f2
) 65.02%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @alecandido for the review. I addressed all the comments except the unresolved that have been linked to issues.
@hay-k can you please review this PR, because soon the lab may decide to connect QM to some chip and the current driver on main does not support Octave devices as we received later than the original cluster. If you don't have time let us know and I can ask someone else to review.
I agree with @igres26 about merging, we could keep improving in further PRs, but at least we'd have (even preliminary) support for the Octaves.
Updates the Quantum Machines driver to support Octave devices. Platforms can now be defined with or without Octaves. OPX+ and Octave controllers are exposed as different objects in order to provide the corresponding ports.
qm-qua has been updated to the latest version that supports the current firmware of our cluster.
This has been tested with the instruments but without a qubit connected.
Potentially helpful for review:
find_sweeper_duration_pulses
andSequence.create
were moved from sequence.py to controller.py.Checklist: