qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
42 stars 14 forks source link

Drop `.settings` in Qblox modules #736

Closed PiergiorgioButtarini closed 6 months ago

PiergiorgioButtarini commented 10 months ago

This PR remove the necessity of having the attribute .settings in each qblox module to store the settings loaded from the runcard. This was unnecessary since the port object already has the possibility to cache this values. This PR also fix the test for Qblox controller (thanks @stavros11). Closes #724

Note:

Checklist:

alecandido commented 9 months ago

Some trivial metrics (trivial, but still pleasing)

# main                        # HEAD
    143 acquisition.py            143 acquisition.py
    758 cluster_qcm_bb.py         685 cluster_qcm_bb.py
    759 cluster_qcm_rf.py         672 cluster_qcm_rf.py
   1039 cluster_qrm_rf.py         952 cluster_qrm_rf.py
    541 controller.py             524 controller.py
     57 debug.py                   57 debug.py
     61 module.py                 157 module.py
    284 port.py                   284 port.py
    370 q1asm.py                  370 q1asm.py
    234 sequencer.py              234 sequencer.py
    397 sweeper.py                402 sweeper.py
   4643 total                    4480 total
codecov-commenter commented 9 months ago

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (8bb0327) 63.89% compared to head (614e301) 64.17%.

Files Patch % Lines
src/qibolab/instruments/qblox/cluster_qrm_rf.py 36.36% 7 Missing :warning:
src/qibolab/instruments/qblox/port.py 72.00% 7 Missing :warning:
src/qibolab/instruments/qblox/cluster_qcm_bb.py 54.54% 5 Missing :warning:
src/qibolab/instruments/qblox/cluster_qcm_rf.py 72.72% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #736 +/- ## ========================================== + Coverage 63.89% 64.17% +0.27% ========================================== Files 49 49 Lines 5792 5792 ========================================== + Hits 3701 3717 +16 + Misses 2091 2075 -16 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/736/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/736/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `64.17% <69.01%> (+0.27%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecandido commented 6 months ago

Superseded by #868 and the subsequent rewriting