codecov[bot]
commented
10 months ago Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.
Comparison is base (
0765763) 62.94% compared to head (9fc2b9c) 63.00%.
| Files | Patch % | Lines |
|---|---|---|
| src/qibolab/platform.py | 83.33% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #737 +/- ## ========================================== + Coverage 62.94% 63.00% +0.05% ========================================== Files 49 49 Lines 6399 6409 +10 ========================================== + Hits 4028 4038 +10 Misses 2371 2371 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/737/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/737/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `63.00% <95.55%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #678 and also adds CNOT as a possible two-qubit native gate. I added a CNOT in the dummy platform as a proof-of-concept and for testing.
This may also be fix #677 as it is possible to add drive pulses of different frequencies acting on arbitrary qubits under the two-qubit section of the runcard. This may be sufficient to implement two-qubit gates using cross resonance (to be confirmed).
Checklist: