the name Cluster in ClusterQCM_BB is redundant, because it inherits from ClusterModule, and QCM_BB is already enough to identify it
QCM_BB does not respect the conventions on class naming, because of the underscores, the valid alternatives are QCMBB, or (the more recommended) QcmBb (it is quite customary to treat acronyms as regular words in identifiers)
Side note, for a further PR:
Cluster
inClusterQCM_BB
is redundant, because it inherits fromClusterModule
, andQCM_BB
is already enough to identify itQCM_BB
does not respect the conventions on class naming, because of the underscores, the valid alternatives areQCMBB
, or (the more recommended)QcmBb
(it is quite customary to treat acronyms as regular words in identifiers)_Originally posted by @AleCandido in https://github.com/qiboteam/qibolab/pull/686#discussion_r1444626006_