search

qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
41 stars 12 forks source link

Remove transpiler-related tutorial #763

Closed alecandido closed 7 months ago

alecandido commented 7 months ago

The transpiler has been moved to Qibo a while ago, so I'd consider this a leftover. In case there is something to be moved before dropping here (or right after) let's do it quickly, or otherwise postpone it until it will be relevant (i.e. let's not block the update of Qibolab behind the update of Qibo, since having two outdated docs is worse than a single one).

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1723585) 62.54% compared to head (c1596a3) 62.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #763 +/- ## ======================================= Coverage 62.54% 62.54% ======================================= Files 47 47 Lines 5882 5882 ======================================= Hits 3679 3679 Misses 2203 2203 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/763/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/763/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `62.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stavros11 commented 7 months ago

Thanks @AleCandido. I agree with removing, I would just prefer to open a PR copying this in Qibo before merging, so that it does not get lost in the abyss. Unless it is already there. I can have a look and do it.

stavros11 commented 7 months ago

I had a look in Qibo and there is already an example about how to modify the transpiler, so no need to move anything there. However, the tutorial here also talks about how to modify the compiler and plug it to the QibolabBackend which is not covered in Qibo and is still part of qibolab code. Therefore, I would only remove the transpiler part and keep the rest, maybe modifying the title and the text a bit.

@AleCandido I can do it pushing to this branch, if you agree.

alecandido commented 7 months ago

I had a look in Qibo and there is already an example about how to modify the transpiler, so no need to move anything there.

Sorry: I actually already had a look yesterday, so I knew it (I could have written in the OP).

However, the tutorial here also talks about how to modify the compiler and plug it to the QibolabBackend which is not covered in Qibo and is still part of qibolab code. Therefore, I would only remove the transpiler part and keep the rest, maybe modifying the title and the text a bit.

@AleCandido I can do it pushing to this branch, if you agree.

If you wish, that's fine. Just change the name of the file and title with the substitution transpiler -> compiler, and truncate the transpiler-specific part.