search

qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
41 stars 12 forks source link

Remove `_if` from `Pulse` #768

Closed alecandido closed 7 months ago

alecandido commented 7 months ago

Following @PiergiorgioButtarini removal of last usage in Qblox, in #729

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f10ba3a) 61.72% compared to head (7b43744) 61.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## simplify-pulse-5 #768 +/- ## ==================================================== + Coverage 61.72% 61.73% +0.01% ==================================================== Files 47 47 Lines 5722 5721 -1 ==================================================== Hits 3532 3532 + Misses 2190 2189 -1 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/768/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/768/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `61.73% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecandido commented 7 months ago

Since I should adapt a small part of the code in Qblox to work with this modification should I open a PR now and reference this PR or should I wait until all the pulse refactor is completed?

If you want to do it now, yes.

If you'd prefer to do it later, you will to use 0.2 (unless you want to wait a lot, such that 0.2 will be in main, but it will take some time and testing).

PiergiorgioButtarini commented 7 months ago

Ok thanks, since I'm going a lot in the lab I will do it asap but not immediately. I'm opening an issue about it so that I remember to implement this changes.