search

qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
41 stars 12 forks source link

C/C++ wrapper #770

Closed scarrazza closed 7 months ago

scarrazza commented 7 months ago

Adds an optional C-API to execute QASM circuits.

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c035b25) 62.48% compared to head (c6ebf97) 62.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## execute_from_qasm #770 +/- ## ================================================== Coverage 62.48% 62.48% ================================================== Files 47 47 Lines 5872 5872 ================================================== Hits 3669 3669 Misses 2203 2203 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/770/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/770/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `62.48% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecandido commented 7 months ago

Should we add at a least a minimal workflow for compiling and running just the example?

scarrazza commented 7 months ago

@alecandido I believe the readme contains already this information, right?

alecandido commented 7 months ago

@alecandido I believe the readme contains already this information, right?

Not because of the information, just to check that the example keeps compiling and running (even though we'd avoid testing the actual result).

scarrazza commented 7 months ago

Ah, are you talking about github workflow?

alecandido commented 7 months ago

Ah, are you talking about github workflow?

Indeed

stavros11 commented 7 months ago

@scarrazza sorry, I think this was closed because I removed the branch it is pointing to (because it was already merged to main). Can you please point to main and reopen? I cannot do it.

scarrazza commented 7 months ago

@stavros11 don't worry, I know you hate C/C++ XD. I have reopened in https://github.com/qiboteam/qibolab/pull/772.