qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
41 stars 12 forks source link

C/C++ wrapper #772

Closed scarrazza closed 7 months ago

scarrazza commented 7 months ago

Adds an optional C-API to execute QASM circuits.

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (900fccf) 62.48% compared to head (c5bdd9d) 62.48%. Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #772 +/- ## ======================================= Coverage 62.48% 62.48% ======================================= Files 47 47 Lines 5872 5872 ======================================= Hits 3669 3669 Misses 2203 2203 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/772/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/772/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `62.48% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecandido commented 7 months ago

@scarrazza the workflow is working on Ubuntu. I wanted to try also on MacOS and Windows, but it on Windows (at least) is failing.

The reason is trivial: it seems like the activate script is generated at a different path inside the virtual environment (i.e. env/Scripts/activate, instead of the usual env/bin/activate). I can easily fix that, but it would (slightly) complicate the workflow...

My question is: do we care at all about running on Windows?

scarrazza commented 7 months ago

Thanks, we can drop windows for this test.