Closed alecandido closed 7 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
a5b7248
) 61.94% compared to head (ba476ee
) 61.68%.
Files | Patch % | Lines |
---|---|---|
src/qibolab/pulses/shape.py | 82.60% | 4 Missing :warning: |
src/qibolab/instruments/qblox/sequencer.py | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Now
Waveform
is only useful as a type hint.There is only one caveat:
Waveform
was hashable,np.ndarray
is not (because mutable). The gap was filled by callingarray.tobytes()
(since the generated bytes are immutable, as a snapshot of an array at a specific time). It's not optimal, since it's still a hash of an actually mutable object, but we just have to be consistent.However, I'm still using the trick explicitly in QM. Are you aware of any other place where the
Waveform
had to be hashable?