Closed alecandido closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d869de0
) 63.81% compared to head (2b96468
) 63.81%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It is fine by me, supposing json will reduce complexity in terms of dependencies.
@andrea-pasquale @alecandido I spoke with @aorgazf and he also agrees with this change, so if this is ready we can merge and I will propagate the changes to qibolab_platforms_qrc.
@andrea-pasquale @alecandido I spoke with @aorgazf and he also agrees with this change, so if this is ready we can merge and I will propagate the changes to qibolab_platforms_qrc.
Good, @stavros11 I might have the majority of the JSON ready for qibolab_platform_qrc
. I can take of that if you want.
@stavros11 now it is merged. It will be anyhow in the next release, so no need to rush for the changes in the qibolab_platforms_qrc
(for as long as people will use the latest release, of course it will be required for testing new PRs in Qibolab)
Good, @stavros11 I might have the majority of the JSON ready for
qibolab_platform_qrc
. I can take of that if you want.
Thanks, if you already have them feel free to open a PR. Otherwise I will do it later or tomorrow.
@stavros11 now it is merged. It will be anyhow in the next release, so no need to rush for the changes in the
qibolab_platforms_qrc
(for as long as people will use the latest release, of course it will be required for testing new PRs in Qibolab)
I am not sure if there is anyone (other than qibocal CI) that is using releases, but in any case it will be useful to have at least a PR with the json runcards to be able to keep developing on qibolab main.
I believe Qibocal should usually develop against releases, and only sometimes using the Git version (when a new Qibolab feature is strictly required).
Indeed with the current workflow Qibocal is only working with releases. This is why usually I push for qibolab releases π
This is why usually I push for qibolab releases π
I know, this is the unpleasant part, and the motivation for monorepos. However, hopefully it will happen less and less :)
Closes #762