Closed stavros11 closed 4 months ago
Thanks, the only issue is that doctest requires qibo to be updated, because qibo.set_backend
is currently using the removed path argument.
Thanks, the only issue is that doctest requires qibo to be updated, because
qibo.set_backend
is currently using the removed path argument.
Ahhh, too many repositories.
Btw, shall we release qibolab now that the milestone is complete? @scarrazza @stavros11 @alecandido I know that maybe some changes were not tested on hardware but I will be able to merge some PRs in qibocal as soon as we release qibolab.
Btw, shall we release qibolab now that the milestone is complete? @scarrazza @stavros11 @alecandido I know that maybe some changes were not tested on hardware but I will be able to merge some PRs in qibocal as soon as we release qibolab.
Fine by me :)
@andrea-pasquale fine by me too.
@andrea-pasquale @alecandido I updated qibo to 0.2.6. As soon as CI passes, I will merge this.
@andrea-pasquale @alecandido I updated qibo to 0.2.6. As soon as CI passes, I will merge this.
= 46 failed, 2198 passed, 104 skipped, 47 deselected, 3 xfailed, 3 xpassed, 5 warnings in 18.20s =
bad luck...
@alecandido in 2603611562e45f05a59e9cd08f9e541e0c325266 I dropped the default transpiler from QibolabBackend
. This is a significant change because it will no longer be possible to run circuits that contain non-native gates out-of-the box, including through the openqasm, C and Rust APIs (btw I also pushed a fix for these tests but for some reason github doesn't show it).
The reason for dropping is that otherwise we are testing the transpiler in qibolab tests while the code is in qibo (which leads to the failures above). It is still possible to add a transpiler of choice manually:
backend = QibolabBackend("my_platform")
backend.transpiler = ... # my transpiler imported from qibo
or even better the user transpiles their circuit manually:
backend = QibolabBackend("my_platform")
circuit = Circuit(...)
...
native_circuit = my_transpiler(circuit)
result = backend.execute_circuit(native_circuit)
After https://github.com/qiboteam/qibolab/actions/runs/8360122834/job/22885054536?pr=784 I think I should officially give up
Cannot install setuptools.
Attention: Patch coverage is 90.90909%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 66.57%. Comparing base (
535dcdb
) to head (21369b5
).
Files | Patch % | Lines |
---|---|---|
src/qibolab/backends.py | 85.71% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yes, please, just merge.
All in all, Qibolab is the low-level layer, it is fine to require circuits to be transpiled by someone else (i.e. Qibo).
Following the discussion in https://github.com/qiboteam/qibolab_platforms_qrc/pull/108#discussion_r1467390932.
I believe some lines in qibo (and maybe also qibocal) need to be updated.
Checklist: