Closed alecandido closed 5 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
b692e60
) 64.26% compared to head (fb0ef12
) 64.43%.
Files | Patch % | Lines |
---|---|---|
src/qibolab/instruments/qblox/sequencer.py | 28.57% | 5 Missing :warning: |
src/qibolab/instruments/qblox/acquisition.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@hay-k I should have addressed all your comments, and the branch has been rebased on the current 0.2
.
If you agree, I'd merge the branch (formal approvals are not required, since it's not targeting main
, but I preferred to tell you, since it will be hard to review within 0.2
).
Thanks @stavros11 and @hay-k for the review!
Software (de)modulation was currently entangled with the
PulseShape
class, and often repeated in the drivers. The goal is just to simplify the presence of software modulation, for the cases in which is still used.tests.pulses.test_shape
, still usingmodulated_waveform_i/q
(de)modulate
functions (possibly reusing pre-existing ones, from pulses themselves or Qblox)pulses.plot
, using explicitlymodulate()
tests.pulses.plot