Closed andrea-pasquale closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
154aab0
) 63.97% compared to head (2578bb2
) 63.97%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@andrea-pasquale I abused your branch to make a further proposal (based on yours), it was easier showing than describing. The motivations are in the commit message.
If you don't like it, feel free to revert.
Btw, the citation policy section is pointing to Qibo, where (correctly?) the Qibolab paper is not listed.
We should decide if keeping each package references separate, and then update those that or not Qibo, or otherwise update Qibo with (at least) the Qibolab paper. @scarrazza
@andrea-pasquale I abused your branch to make a further proposal (based on yours), it was easier showing than describing. The motivations are in the commit message.
If you don't like it, feel free to revert.
I like your proposal. I wanted to start a discussion to see which ones we should keep and which one we can remove.
Perhaps I would add again tests
, codefactor
also would be nice but I think that people probably don't care.
Perhaps I would add again
tests
,codefactor
also would be nice but I think that people probably don't care.
Feel free :)
(for Codefactor in particular, I personally feel a bit guilty, given the amount of ignored Pylint warnings...)
Thanks for fixing this @andrea-pasquale. Personally I would add at least the "tests" badge because we have it in other repositories, but either way is fine with me.
@stavros11 the idea of @andrea-pasquale (if I understood correctly), was to make a proposal to then propagate to the other repos as well. So, it would be fine to have something different (for the time being).
I proposed to have only Codecov, because if Codecov is working tests are passing (they are related to the same topic). But if you want to have it explicit, just add it.
@stavros11 the idea of @andrea-pasquale (if I understood correctly), was to make a proposal to then propagate to the other repos as well. So, it would be fine to have something different (for the time being).
Indeed, I will propagate these changes to all our repos. Regarding tests in theory we should also be able to see if tests are passing or no by checking the last commit which is always shown on GitHub therefore it might be redundant also for this reason.
I've fixed the
tests
badge and I've also added others badges. We can even drop some of them I just wanted to make theREADME
look nicer. I could also propagate some of those changes to the other repos.Checklist: