qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
41 stars 10 forks source link

Missing PyVISA dependency to LO extra #824

Closed alecandido closed 4 months ago

alecandido commented 4 months ago

I got:

RuntimeError: Cannot establish connection to <qibolab.instruments.rohde_schwarz.SGS100A object at 0x7f69a346fca0> instruments. Error captured: 'Could not locate a VISA implementation. Install either the IVI binary or pyvisa-py.'

while debugging https://github.com/qiboteam/qibocal/issues/737.

I know we are not importing it, but it seems like it's a requirement we're getting through the qcodes drivers (I believe they are not declaring it because there are multiple implementations, and the standard one is even non-Python, like it is happening for OpenSSL and similar).

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.13%. Comparing base (d080141) to head (312b3af).

:exclamation: Current head 312b3af differs from pull request most recent head a2a7f63. Consider uploading reports for the commit a2a7f63 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #824 +/- ## ========================================== + Coverage 65.09% 65.13% +0.03% ========================================== Files 50 50 Lines 6034 6031 -3 ========================================== Hits 3928 3928 + Misses 2106 2103 -3 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/824/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/824/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `65.13% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.