qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
41 stars 10 forks source link

Fix result shapes #825

Closed alecandido closed 4 months ago

alecandido commented 4 months ago

Currently, result shapes are broken for the QICK drivers, as reported by @JavierSerranoGarcia in https://github.com/qiboteam/qibocal/issues/737

However, it seems like the tests in https://github.com/qiboteam/qibolab/blob/595351782d55a20fa2b8c35104c000092e42f585/tests/test_result_shapes.py are also broken for iqm5q (currently using Zurich, in a pretty weird way.

I'm trying to understand how this is happening, but Qibocal seems properly compensating, since the resonator_spectroscopy routine is then properly working.

Checklist:

alecandido commented 4 months ago

Maybe @hay-k could also have an idea, given his work on #797

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.13%. Comparing base (5953517) to head (f5b2692).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #825 +/- ## ======================================= Coverage 65.13% 65.13% ======================================= Files 50 50 Lines 6031 6031 ======================================= Hits 3928 3928 Misses 2103 2103 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/825/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/825/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `65.13% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecandido commented 4 months ago

Superseded by #843