qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
40 stars 10 forks source link

Fix drag pulse helper method #835

Closed andrea-pasquale closed 3 months ago

andrea-pasquale commented 3 months ago

While testing https://github.com/qiboteam/qibocal/pull/689 I noticed that the platform's helper methods for creating drag pulses were broken (I was the one who implemented them...). This PR fixes the issue.

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.51%. Comparing base (aa1d165) to head (80907cf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #835 +/- ## ========================================== + Coverage 66.35% 66.51% +0.16% ========================================== Files 50 50 Lines 6063 6063 ========================================== + Hits 4023 4033 +10 + Misses 2040 2030 -10 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/835/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `66.51% <100.00%> (+0.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.