qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
40 stars 10 forks source link

Bluefors cryo temperature controller #842

Closed GabrielePalazzo closed 3 months ago

GabrielePalazzo commented 3 months ago

@alecandido, @scarrazza, @stavros11 if you agree, we should continue here.

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.23%. Comparing base (53d6ea1) to head (11cfa8d). Report is 116 commits behind head on main.

Files Patch % Lines
src/qibolab/instruments/bluefors.py 96.15% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #842 +/- ## ========================================== + Coverage 65.09% 65.23% +0.13% ========================================== Files 50 51 +1 Lines 6034 6060 +26 ========================================== + Hits 3928 3953 +25 - Misses 2106 2107 +1 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/842/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/842/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `65.23% <96.15%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecandido commented 3 months ago

The moment this will get merged, I'd proceed to close #834 and #594.