codecov[bot]
commented
3 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 66.75%. Comparing base (
abe3698) to head (0d6c4b5).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #856 +/- ## ========================================== + Coverage 66.66% 66.75% +0.08% ========================================== Files 55 55 Lines 5901 5916 +15 ========================================== + Hits 3934 3949 +15 Misses 1967 1967 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/856/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/856/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `66.75% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We found that using the
always_onmode leaves the LOs on even after execution. This may cause issues related to LO leakage, if the mixers are not calibrated and the LO gain is very high. Using thetriggeredmode allows the LO signal to pass only when something is playing in the corresponding port, by sending a simultaneous digital trigger.I have done some quick tests with qw5q_platinum and this seems to maintain results. I have not confirmed whether the LOs are really turned off.