Closed alecandido closed 2 months ago
Currently, it is at the stage of just an interface proposal, but it would require to propagate the sweeper
usage to all the Controller.play()
definitions, and drop the .sweep()
(on top of fixing tests).
@stavros11 @hay-k the biggest change is (of course) in qibolab.platform.platform
, where the previous methods have been replaced by the unique Platform.execute()
, and in qibolab.instruments.abstract
, where Controller.sweep()
has been suppressed.
Everything else is just a matter of propagating these changes and fixing the tests.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 44.93%. Comparing base (
673425d
) to head (79b5c14
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@stavros11 thanks for your comments: I would avoid implementing both, even the docstring, because the current result is not here to stay.
Current patches are there because it's useful to have tests passing, even for a work-in-progress 0.2 version, but they will also change as a consequence of new developments concerning the results.
I would close this as it is, unless you or @hay-k have any other comments.
To move forward, if no other feedback will be collected, I will merge on Monday/Tuesday (in this case approvals are only informal, since we're not merging to main
), and then start working asap on #809 and #899. @stavros11 if you can provide some support, we could even prototype the results' generation in QM. I will start defining the interface and implementing for dummy.
I would close this as it is, unless you or @hay-k have any other comments. To move forward, if no other feedback will be collected, I will merge on Monday/Tuesday (in this case approvals are only informal, since we're not merging to
main
), and then start working asap on #809 and #899.
No comments from my side, I agree with the plan and merging this as it is. I also agree with the summary in the issues.
@stavros11 if you can provide some support, we could even prototype the results' generation in QM. I will start defining the interface and implementing for dummy.
Sure, when you define the interface I will propagate it to QM.
As previously announced, I'm merging this, and keep going with #809 and #899.
Thanks @stavros11 for your review. I will keep into account in those issues (I'm going to directly cite it in there)
Close #755
Controller.play()
Controller.sweep()