qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
43 stars 14 forks source link

RFSoC interpolated channel #863

Closed rodolfocarobene closed 2 months ago

rodolfocarobene commented 6 months ago

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.60%. Comparing base (76def93) to head (b65289f).

Files Patch % Lines
src/qibolab/instruments/rfsoc/driver.py 75.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #863 +/- ## ========================================== + Coverage 66.59% 66.60% +0.01% ========================================== Files 55 55 Lines 5942 5953 +11 ========================================== + Hits 3957 3965 +8 - Misses 1985 1988 +3 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/863/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/863/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `66.60% <75.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rodolfocarobene commented 2 months ago

I'm closing this as we did for the qibosoq PR. This does not seem so important or useful for the moment