qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
43 stars 14 forks source link

Remove `FluxPulse` from serialization PR #892

Closed stavros11 closed 5 months ago

stavros11 commented 5 months ago

Addresses https://github.com/qiboteam/qibolab/pull/870#discussion_r1576109435.

Of course the platforms in qibolab_platforms_qrc also need to be updated, but these are already broken in 0.2 for other reasons, so I wouldn't bother for now. We will update them anyway when 0.2 is ready.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.74%. Comparing base (f00e01f) to head (4cfad5e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## propagate-serialization #892 +/- ## =========================================================== - Coverage 48.79% 48.74% -0.06% =========================================================== Files 61 61 Lines 5535 5529 -6 =========================================================== - Hits 2701 2695 -6 Misses 2834 2834 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/892/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/892/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `48.74% <100.00%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecandido commented 5 months ago

I've been lazy. Thanks to have done it properly :)