Closed andrea-pasquale closed 1 month ago
Attention: Patch coverage is 78.57143%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 66.62%. Comparing base (
41fcafd
) to head (e1a7f84
). Report is 28 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/qibolab/result.py | 78.57% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In long term I agree that these result classes should be revisited and simplified.
Since it's only listed in the events, but not linked in any comment, let me note explicitly that it has already been scheduled for 0.2 https://github.com/qiboteam/qibolab/issues/899
I could provide a PR with the *Result
s removal, and basic replacement in the common layer. However, replacing with just arrays means that most of the work will have to be done in the drivers (just returning arrays instead of *Result
) and Qibocal (handling it properly).
Required by https://github.com/qiboteam/qibocal/pull/832 This PR "corrects" the
average
property ofAveragedIntegratedResults
by returning the object itself without performing the average again. I've also added the propertyphase_std
which is useful for qibocal (if you think that it is not necessary I can always drop it and do it directly in qibocal). I'm keeping it as draft to account for any possible changes in https://github.com/qiboteam/qibocal/pull/832EDIT: I've also implemented #897 here. Checklist: