qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
40 stars 10 forks source link

Collect frequencies before processing sweeps #902

Closed hay-k closed 1 month ago

hay-k commented 1 month ago

Processed sweeps uses frequency from characterization section. This leads to inconsistency when user updates the frequency of native pulse, but does not update the characterization section (e.g. readout_frequency). This change fixes this inconsistency.

All of this is being removed for 0.2 release (https://github.com/qiboteam/qibolab/pull/885). This fix is needed for short term, before the realease.

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.64%. Comparing base (b93ee1b) to head (5f5f54a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #902 +/- ## ======================================= Coverage 66.64% 66.64% ======================================= Files 55 55 Lines 5954 5954 ======================================= Hits 3968 3968 Misses 1986 1986 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/902/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `66.64% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.