qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
40 stars 10 forks source link

Hotfix to allow playing different frequencies on the same qubit with QM #905

Closed stavros11 closed 1 month ago

stavros11 commented 1 month ago

I am not sure if I would merge that because it was a very quick and messy fix, but we should certainly support it on all drivers for 0.2

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.82%. Comparing base (a964ab2) to head (dd70a1b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #905 +/- ## ========================================== + Coverage 66.64% 66.82% +0.18% ========================================== Files 55 55 Lines 5954 5969 +15 ========================================== + Hits 3968 3989 +21 + Misses 1986 1980 -6 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/905/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/905/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `66.82% <100.00%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stavros11 commented 1 month ago

Following today's discussion, we could probably merge this for the release tomorrow. I just implemented multiple frequencies on the same qubit for readout as well. I only implemented it for when using Octaves, not external mixers, as this is sufficient for the current qw5q_platinum platform.

The change may not be optimal codewise, but I wouldn't spend more time as long as it works, as this part will be completely refactored in 0.2 (using channel names instead of hardcoding the element names, etc.).

scarrazza commented 1 month ago

@alecandido @Edoardo-Pedicillo @andrea-pasquale could you please review this asap?