qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
43 stars 14 forks source link

Fixes late comments on #905 #908

Closed stavros11 closed 4 months ago

stavros11 commented 4 months ago

Fixes https://github.com/qiboteam/qibolab/pull/905#discussion_r1611819168 and https://github.com/qiboteam/qibolab/pull/905#discussion_r1613546747. The second is minor and should not have effects on execution, however the first should affect the case where multiple frequencies are used on the same qubit for readout, which probably doesn't work correctly in the previous implementation.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.81%. Comparing base (7868bfe) to head (d70c0b5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #908 +/- ## ======================================= Coverage 66.81% 66.81% ======================================= Files 55 55 Lines 5970 5970 ======================================= Hits 3989 3989 Misses 1981 1981 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/908/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `66.81% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.