qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
43 stars 14 forks source link

Fix loading of string qubit names #926

Closed stavros11 closed 3 months ago

stavros11 commented 3 months ago

Removes the annoying \" from qubit names when they are strings in the parameters.json. Also, the loading/dumping is now consistent for platforms with string qubit names and therefore we can copy new_platform parameters produced from qibocal.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.32%. Comparing base (2b68ee2) to head (bde4638).

Files Patch % Lines
src/qibolab/serialize.py 85.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #926 +/- ## ========================================== + Coverage 70.30% 70.32% +0.01% ========================================== Files 64 64 Lines 6665 6679 +14 ========================================== + Hits 4686 4697 +11 - Misses 1979 1982 +3 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/926/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `70.32% <85.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.