qiboteam / qibolab

Quantum hardware module and drivers for Qibo.
https://qibo.science
Apache License 2.0
41 stars 10 forks source link

Switch reusable workflows to v1, instead of main #930

Closed alecandido closed 1 week ago

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.32%. Comparing base (d2c5f89) to head (85a46cc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #930 +/- ## ======================================= Coverage 70.32% 70.32% ======================================= Files 64 64 Lines 6679 6679 ======================================= Hits 4697 4697 Misses 1982 1982 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibolab/pull/930/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibolab/pull/930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `70.32% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecandido commented 2 weeks ago

I might have missed some discussion, but is there any reason we are switching all repositories to v1, instead of just merging v1 to main of the repository with the workflows?

https://github.com/qiboteam/workflows/issues/12

Moreover: as soon as the switch will be completed, I will change default branch in the workflows repo. At that point, main will be deprecated, and at some point even removed.

alecandido commented 2 weeks ago

@Edoardo-Pedicillo