qiboteam / qiboml

Quantum Machine Learning using Qibo
Apache License 2.0
9 stars 3 forks source link

Refactor `backends`: migrating `pytorch` and creating `jax` #12

Closed MatteoRobbiati closed 5 months ago

alecandido commented 5 months ago

Just a guess but... I believe you did not receive any feedback on this PR, because you didn't ask anyone :P

Btw, this is targeting https://github.com/qiboteam/qiboml/tree/expectation that has not even a PR... Since qiboml is experimental anyhow, to reduce the complexity of open PRs I'd just merge expectation into main, and then backends into main as well. We could keep improving their content in further PRs.

MatteoRobbiati commented 5 months ago

Just a guess but... I believe you did not receive any feedback on this PR, because you didn't ask anyone :P

Ups :)

Btw, this is targeting https://github.com/qiboteam/qiboml/tree/expectation that has not even a PR... Since qiboml is experimental anyhow, to reduce the complexity of open PRs I'd just merge expectation into main, and then backends into main as well. We could keep improving their content in further PRs.

I changed the targeted branch into main since there are no conflicts anyway.

alecandido commented 5 months ago

I changed the targeted branch into main since there are no conflicts anyway.

Then you can just merge :)

(but please, merge also expectation, since the other PRs will work on top of that)

It seems that it has already been merged in #9. Then, just delete the branch.

alecandido commented 5 months ago

@scarrazza is it possible to enable branch autodeletion?

image

In this way the PRs will be retargeted automatically (now I realized: this was based on #9, and simply not updated after that one got merged).

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 193 lines in your changes are missing coverage. Please review.

Project coverage is 16.62%. Comparing base (151f54e) to head (09e5d82).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/qiboteam/qiboml/pull/12/graphs/tree.svg?width=650&height=150&src=pr&token=9HMBD3N3D6&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam)](https://app.codecov.io/gh/qiboteam/qiboml/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) ```diff @@ Coverage Diff @@ ## main #12 +/- ## =========================================== - Coverage 29.67% 16.62% -13.05% =========================================== Files 6 8 +2 Lines 246 439 +193 =========================================== Hits 73 73 - Misses 173 366 +193 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qiboml/pull/12/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qiboml/pull/12/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `16.62% <0.00%> (-13.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/qiboteam/qiboml/pull/12?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [src/qiboml/backends/jax.py](https://app.codecov.io/gh/qiboteam/qiboml/pull/12?src=pr&el=tree&filepath=src%2Fqiboml%2Fbackends%2Fjax.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9tbC9iYWNrZW5kcy9qYXgucHk=) | `0.00% <0.00%> (ø)` | | | [src/qiboml/backends/pytorch.py](https://app.codecov.io/gh/qiboteam/qiboml/pull/12?src=pr&el=tree&filepath=src%2Fqiboml%2Fbackends%2Fpytorch.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9tbC9iYWNrZW5kcy9weXRvcmNoLnB5) | `0.00% <0.00%> (ø)` | |
scarrazza commented 5 months ago

@alecandido, done together with branch protection (main).

alecandido commented 5 months ago

@scarrazza maybe it does not apply to existing PRs? https://github.com/qiboteam/qiboml/pull/19 image

In any case, if it's not already like that, can you make branch protection with single reviewer? Just for the time being, since the project is rather small (so it is experimental, and quickly iterating). However, it's just a temporary measure, not really top-priority anyhow.

scarrazza commented 5 months ago

Probably yes, it is already si already reviewer.