Closed MatteoRobbiati closed 5 months ago
Just a guess but... I believe you did not receive any feedback on this PR, because you didn't ask anyone :P
Ups :)
Btw, this is targeting https://github.com/qiboteam/qiboml/tree/expectation that has not even a PR... Since
qiboml
is experimental anyhow, to reduce the complexity of open PRs I'd just mergeexpectation
intomain
, and thenbackends
intomain
as well. We could keep improving their content in further PRs.
I changed the targeted branch into main since there are no conflicts anyway.
I changed the targeted branch into main since there are no conflicts anyway.
Then you can just merge :)
(but please, merge also expectation
, since the other PRs will work on top of that)
It seems that it has already been merged in #9. Then, just delete the branch.
@scarrazza is it possible to enable branch autodeletion?
In this way the PRs will be retargeted automatically (now I realized: this was based on #9, and simply not updated after that one got merged).
Attention: Patch coverage is 0%
with 193 lines
in your changes are missing coverage. Please review.
Project coverage is 16.62%. Comparing base (
151f54e
) to head (09e5d82
).
@alecandido, done together with branch protection (main).
@scarrazza maybe it does not apply to existing PRs? https://github.com/qiboteam/qiboml/pull/19
In any case, if it's not already like that, can you make branch protection with single reviewer? Just for the time being, since the project is rather small (so it is experimental, and quickly iterating). However, it's just a temporary measure, not really top-priority anyhow.
Probably yes, it is already si already reviewer.
Just a guess but... I believe you did not receive any feedback on this PR, because you didn't ask anyone :P
Btw, this is targeting https://github.com/qiboteam/qiboml/tree/expectation that has not even a PR... Since
qiboml
is experimental anyhow, to reduce the complexity of open PRs I'd just mergeexpectation
intomain
, and thenbackends
intomain
as well. We could keep improving their content in further PRs.