search

qiboteam / qiboml

Quantum Machine Learning using Qibo
Apache License 2.0
7 stars 1 forks source link

Workflows #7

Closed Edoardo-Pedicillo closed 3 months ago

Edoardo-Pedicillo commented 3 months ago

This PR deploy the workflows

Edoardo-Pedicillo commented 3 months ago

This PR is ready, but the linting is failing. @MatteoRobbiati could you please fix it?

codecov[bot] commented 3 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

Edoardo-Pedicillo commented 3 months ago

I removed the pdbpp dependency, because it is not strictly related to tests and it cause the following error https://github.com/qibogang/qiboml/actions/runs/8360680848/job/22887073306#step:11:49, it seems one of its dependency py3k_compat is not updated with py 3.10 changes related to Callable (see https://stackoverflow.com/questions/69515086/error-attributeerror-collections-has-no-attribute-callable-using-beautifu)

Edoardo-Pedicillo commented 3 months ago

@MatteoRobbiati do you want me to add the workflows to generate the docs and publish the package, or is it too early?

Edoardo-Pedicillo commented 3 months ago

After speaking with @alecandido, we agree it is better to take the pdbpp dependency and set the dependencies of the dev group optional.

MatteoRobbiati commented 3 months ago

After speaking with @alecandido, we agree it is better to take the pdbpp dependency and set the dependencies of the dev group optional.

Fine with me.

Edoardo-Pedicillo commented 3 months ago

@MatteoRobbiati this PR is ready, let me know how many approvals I need. I opened #8 to implement the other workflows.