qiboteam / qibosoq

Qibo server for Qick
https://qibo.science
Apache License 2.0
11 stars 2 forks source link

Update Qick to 0.2.249 #111

Closed rodolfocarobene closed 5 months ago

rodolfocarobene commented 6 months ago

Some updates

Checklist before review:

Checklist before merge:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.23%. Comparing base (4fb926d) to head (8b5484d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## qickupdate #111 +/- ## =========================================== Coverage 94.23% 94.23% =========================================== Files 12 12 Lines 711 711 =========================================== Hits 670 670 Misses 41 41 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibosoq/pull/111/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibosoq/pull/111/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `94.23% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rodolfocarobene commented 5 months ago

Hi @alecandido, could you please have a look at this and #102? As far as I know, in the lab they have been using #102 for some time without major problems. Eventually just the ones that I fixed in this PR.

I did all the tests I could, something that is missing (i would like to do it today/tomorrow) is testing with qubits, but since the changes are very limited, I think this may be ready for review

rodolfocarobene commented 5 months ago

@alecandido, I would merge this and the other PR when it is possible. Then wait for some time to give @JavierSerranoGarcia some time for testing on real hardware and then do a release and merge the qibolab PR

rodolfocarobene commented 5 months ago

(I forgot to approve before, but you didn't need my approval, since it's not pointing to main)

This I know it, but I wanted to wait for a formal approval to not exploit the system :-)

As usual, I'd merge first #102, unless you have an explicit motivation to avoid it

I think it's fine, but for #102 I really have to wait for an approval (the changes in that PR, however, are quite minimal and already tested)