Closed rodolfocarobene closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.23%. Comparing base (
4fb926d
) to head (8b5484d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @alecandido, could you please have a look at this and #102? As far as I know, in the lab they have been using #102 for some time without major problems. Eventually just the ones that I fixed in this PR.
I did all the tests I could, something that is missing (i would like to do it today/tomorrow) is testing with qubits, but since the changes are very limited, I think this may be ready for review
@alecandido, I would merge this and the other PR when it is possible. Then wait for some time to give @JavierSerranoGarcia some time for testing on real hardware and then do a release and merge the qibolab PR
(I forgot to approve before, but you didn't need my approval, since it's not pointing to
main
)
This I know it, but I wanted to wait for a formal approval to not exploit the system :-)
As usual, I'd merge first #102, unless you have an explicit motivation to avoid it
I think it's fine, but for #102 I really have to wait for an approval (the changes in that PR, however, are quite minimal and already tested)
Some updates
Checklist before review:
Checklist before merge: