qiboteam / qibosoq

Qibo server for Qick
https://qibo.science
Apache License 2.0
11 stars 2 forks source link

Add support for interpolated channel #113

Closed rodolfocarobene closed 2 months ago

rodolfocarobene commented 5 months ago

I'm adding support for the interpolated channel. This is an easy solution (that should work), but I do not like it much... It is not much clean and does not scale considering the addition of new type of channels (what will I do, continuously add new attributes?). Moreover, it does not solve the problem of having normal readout channels as well as the multiplexed ones. I'm going to think about it a bit more, but in the meantime this is fine.

Checklist before review:

Checklist before merge:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.32%. Comparing base (faa13a2) to head (30aa3de).

Files Patch % Lines
src/qibosoq/programs/base.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ========================================== - Coverage 94.43% 94.32% -0.11% ========================================== Files 12 12 Lines 719 723 +4 ========================================== + Hits 679 682 +3 - Misses 40 41 +1 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibosoq/pull/113/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibosoq/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `94.32% <92.85%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rodolfocarobene commented 4 months ago

Hi @JavierSerranoGarcia, this PR should implement support for interpolated channels.

It has to be tested (with the firmware that you are using at TII) accompanied to this qibolab PR: https://github.com/qiboteam/qibolab/pull/863.

Could you please try and report any error you get? Thanks in advance! :-)

JavierSerranoGarcia commented 4 months ago

Thank you @rodolfocarobene , I will test it ASAP

rodolfocarobene commented 2 months ago

Has this been tested or abandoned @JavierSerranoGarcia? If this has not been properly tested I would propose to just close it (keeping the branch) so that we don't have a perpetual stale PR

JavierSerranoGarcia commented 2 months ago

Hi @rodolfocarobene, I did a quick test and it seemed it works but still not fully tested. Close it and if any problem arises in the future we will open an issue