Closed rodolfocarobene closed 2 months ago
Attention: Patch coverage is 92.85714%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 94.32%. Comparing base (
faa13a2
) to head (30aa3de
).
Files | Patch % | Lines |
---|---|---|
src/qibosoq/programs/base.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @JavierSerranoGarcia, this PR should implement support for interpolated channels.
It has to be tested (with the firmware that you are using at TII) accompanied to this qibolab PR: https://github.com/qiboteam/qibolab/pull/863.
Could you please try and report any error you get? Thanks in advance! :-)
Thank you @rodolfocarobene , I will test it ASAP
Has this been tested or abandoned @JavierSerranoGarcia? If this has not been properly tested I would propose to just close it (keeping the branch) so that we don't have a perpetual stale PR
Hi @rodolfocarobene, I did a quick test and it seemed it works but still not fully tested. Close it and if any problem arises in the future we will open an issue
I'm adding support for the interpolated channel. This is an easy solution (that should work), but I do not like it much... It is not much clean and does not scale considering the addition of new type of channels (what will I do, continuously add new attributes?). Moreover, it does not solve the problem of having normal readout channels as well as the multiplexed ones. I'm going to think about it a bit more, but in the meantime this is fine.
Checklist before review:
Checklist before merge: