qiboteam / qibosoq

Qibo server for Qick
https://qibo.science
Apache License 2.0
11 stars 2 forks source link

First release #44

Closed alecandido closed 1 year ago

alecandido commented 1 year ago

I've just noticed we've never tagged Qibosoq.

Since it's proven working, and we start using this even in other places, I'd suggest tagging the current status of main (once properly tested), and release 0.0.1 on PyPI.

- [x] test current version on QPU
- [x] double check releasing workflow
- [x] tag
scarrazza commented 1 year ago

Sounds good to me.

rodolfocarobene commented 1 year ago

Current main has been tested and (almost) everything seems to be working. Just one thing that I had committed and not pushed in the two-qubits-gate PR... #45 solves an issue encountered in https://github.com/qiboteam/qibolab/pull/474

Other than that, I am not aware of any bug lefts and all the main functionalities are implemented, so I agree that it's time for a release!

rodolfocarobene commented 1 year ago

Now I thing everything is ready :-)

alecandido commented 1 year ago

I checked the workflow, it should be fine (exactly mirroring Qibolab's one, with the addition of py3.8 on Ubuntu).

Please, keep going with the tag.

In case of doubts:

git tag v0.0.1 -m "<your-description>"
git push --tags
scarrazza commented 1 year ago

Let me know when you are ready for a pypi release, I will take care of it.

alecandido commented 1 year ago

Let me know when you are ready for a pypi release, I will take care of it.

I guess when the tag will be uploaded the workflow will just fail because of the missing token. At that point you can manually upload with the temporary token :)

rodolfocarobene commented 1 year ago

Sorry for the delay, I've now uploaded the tag

thanks for the help :-)

alecandido commented 1 year ago

@scarrazza: actually, I forgot we are deploying on releases, not tags.

So it didn't even fail. We just need to upload on PyPI the first tag :)

scarrazza commented 1 year ago

We must create a github release before uploading the artifacts manually to PYPI, this will generate a Zenodo DOI.

alecandido commented 1 year ago

Can you install Release Drafter on this repo?

scarrazza commented 1 year ago

Already installed since the creation of this repo.

scarrazza commented 1 year ago

For the first release you can click on the generate release notes: image

alecandido commented 1 year ago

I see, it has been a while since the last time I've done manually...

scarrazza commented 1 year ago

Make sure to erase and regenerate with the button, even if #46 was merged, quite frequently it misses some stuff.

alecandido commented 1 year ago

I used the button, but it could have been not visible before since I automatically set as pre-release (since 0.0.x ...).

But then I checked Qibolab, and I removed the pre-release label. Do you still see problems with Zenodo?

scarrazza commented 1 year ago

Looks good, here the zenodo entry: https://zenodo.org/record/8083286.

Could you please:

alecandido commented 1 year ago

The second and third point are addressed by #48

About the first point: the workflow is not uploading wheels as artifacts, so I regenerated it offline dist.tar.gz (there is only one wheel, since there is no compiled extension, and I included also the generated source distribution)

scarrazza commented 1 year ago

Ready: https://pypi.org/project/qibosoq/0.0.1/