Closed alecandido closed 1 year ago
Sounds good to me.
Current main has been tested and (almost) everything seems to be working. Just one thing that I had committed and not pushed in the two-qubits-gate PR... #45 solves an issue encountered in https://github.com/qiboteam/qibolab/pull/474
Other than that, I am not aware of any bug lefts and all the main functionalities are implemented, so I agree that it's time for a release!
Now I thing everything is ready :-)
I checked the workflow, it should be fine (exactly mirroring Qibolab's one, with the addition of py3.8 on Ubuntu).
Please, keep going with the tag.
In case of doubts:
git tag v0.0.1 -m "<your-description>"
git push --tags
Let me know when you are ready for a pypi release, I will take care of it.
Let me know when you are ready for a pypi release, I will take care of it.
I guess when the tag will be uploaded the workflow will just fail because of the missing token. At that point you can manually upload with the temporary token :)
Sorry for the delay, I've now uploaded the tag
thanks for the help :-)
@scarrazza: actually, I forgot we are deploying on releases, not tags.
So it didn't even fail. We just need to upload on PyPI the first tag :)
We must create a github release before uploading the artifacts manually to PYPI, this will generate a Zenodo DOI.
Can you install Release Drafter on this repo?
Already installed since the creation of this repo.
For the first release you can click on the generate release notes:
I see, it has been a while since the last time I've done manually...
Make sure to erase and regenerate with the button, even if #46 was merged, quite frequently it misses some stuff.
I used the button, but it could have been not visible before since I automatically set as pre-release (since 0.0.x ...).
But then I checked Qibolab, and I removed the pre-release label. Do you still see problems with Zenodo?
Looks good, here the zenodo entry: https://zenodo.org/record/8083286.
Could you please:
The second and third point are addressed by #48
About the first point: the workflow is not uploading wheels as artifacts, so I regenerated it offline dist.tar.gz (there is only one wheel, since there is no compiled extension, and I included also the generated source distribution)
I've just noticed we've never tagged Qibosoq.
Since it's proven working, and we start using this even in other places, I'd suggest tagging the current status of
main
(once properly tested), and release0.0.1
on PyPI.