qiboteam / qibosoq

Qibo server for Qick
https://qibo.science
Apache License 2.0
12 stars 3 forks source link

custom pulses #59

Closed rodolfocarobene closed 1 year ago

rodolfocarobene commented 1 year ago

Fixes #34.

Checklist before merge:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.72 :tada:

Comparison is base (be4a8d9) 72.42% compared to head (959359e) 73.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== + Coverage 72.42% 73.15% +0.72% ========================================== Files 11 11 Lines 544 555 +11 ========================================== + Hits 394 406 +12 + Misses 150 149 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `73.15% <100.00%> (+0.72%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/qiboteam/qibosoq/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [src/qibosoq/components/pulses.py](https://app.codecov.io/gh/qiboteam/qibosoq/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9zb3EvY29tcG9uZW50cy9wdWxzZXMucHk=) | `100.00% <100.00%> (ø)` | | | [src/qibosoq/programs/base.py](https://app.codecov.io/gh/qiboteam/qibosoq/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#diff-c3JjL3FpYm9zb3EvcHJvZ3JhbXMvYmFzZS5weQ==) | `79.89% <100.00%> (+0.97%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rodolfocarobene commented 1 year ago

This requires a bit of hardware testing, but should be fine. The real changes are related just to the Arbitrary shape, then I simplified slightly the add_register function, but the code itself didn't change

rodolfocarobene commented 1 year ago

Example of weird pulse implemented using Arbitrary :-)

image