qiboteam / qibosoq

Qibo server for Qick
https://qibo.science
Apache License 2.0
12 stars 3 forks source link

Add qubit experiments with qibosoq-lab-cal #84

Closed rodolfocarobene closed 11 months ago

rodolfocarobene commented 1 year ago

This is my proposal to help new users to start using the rfsocs via the qibo ecosystem. We could present different qubit experiments via the qibosoq, qibolab and qibocal interface.

Do you have different ideas?

Checklist before merge:

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ab92b3a) 93.66% compared to head (880c6b2) 93.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #84 +/- ## ======================================= Coverage 93.66% 93.66% ======================================= Files 12 12 Lines 647 647 ======================================= Hits 606 606 Misses 41 41 ``` | [Flag](https://app.codecov.io/gh/qiboteam/qibosoq/pull/84/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qiboteam/qibosoq/pull/84/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam) | `93.66% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiboteam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JavierSerranoGarcia commented 1 year ago

Hi @rodolfocarobene I will test these new scripts Something I missed in the tutorial and it is a big source of problems is the multiplexed readout. Are you planning to add anyone?

rodolfocarobene commented 1 year ago

I'd like first to finish these tutorials. If you want to add something about multiplex (maybe in the Pulse part?) and to fix the errors in the sweeper section I think you can even do it in this PR

rodolfocarobene commented 1 year ago

Thanks @AleCandido for the comments, I will implement them soon. I am planning to add some more text/explanations in all the sections and maybe we could add two/three jupyter notebooks with all the examples sequentially (at least one for qibosoq and one for qibolab)

rodolfocarobene commented 1 year ago

I would merge it when possible

rodolfocarobene commented 11 months ago

Hi! Can someone have a look please? @AleCandido @JavierSerranoGarcia @stavros11 @andrea-pasquale @Edoardo-Pedicillo.

This PR is just about documentation and should not be difficult to review since it does not require testing

rodolfocarobene commented 11 months ago

No problem, thanks for the reviews! I agree that these should be completely tested, but at the moment it's a bit difficult for me. I think it's better to have something, potentially faulty, and as soon as possible check it all

alecandido commented 11 months ago

I agree that these should be completely tested, but at the moment it's a bit difficult for me.

Never said it's simple. But it's not only about testing once, so it's even more complicate...