Modifying the Collection Passed to ofy().save()

[GoogleCodeExporter]

Modifying the collection passed to ofy().save() can cause strange results.  It 
took me a very long time to isolate this problem.  I would like to request 
either "fixing" it, or documenting that the collection should not be modified 
before the results are fetched.

Here is code to show unexpected results:

@Entity
@Cache
public static class TestObj {
    @Id public long id = (long) (Math.random() * 10000);
}

TestObj obj = new TestObj();
ofy().load().entity(obj).now(); // <-- this is necessary
Collection toSave = new ArrayList();
toSave.add(obj);
Result result = ofy().save().entities(toSave);
toSave.clear(); // <-- this is what breaks things
result.now();
ofy().load().entity(obj).now(); // <-- return "null"

Original issue reported on code.google.com by ersim...@gmail.com on 24 Apr 2014 at 11:41

[GoogleCodeExporter]

Interesting. Let's consider that a bug.

Original comment by lhori...@gmail.com on 24 Apr 2014 at 11:54

• Changed state: Accepted
• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Fixed in 5.0.3

Original comment by lhori...@gmail.com on 30 Apr 2014 at 6:46

• Changed state: Fixed

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Thanks!

Original comment by ersim...@gmail.com on 30 Apr 2014 at 6:48