qiime / qiime_web_app

QIIME, EMP and American Gut Web Application
www.microbio.me/qiime
9 stars 10 forks source link

Update Barcode Scanner #632

Open teravest opened 10 years ago

teravest commented 10 years ago

Addresses issue #626

This updates the barcode scanner to be able to edit the fields in the barcode table.

I also created a controlled vocabulary for the sequencing_status column.

I also rewrote a giant req.write in barcode_utils.psp so that it was in html instead of a string.

ElDeveloper commented 10 years ago
teravest commented 10 years ago

Ok all these changes should be made with the info we have right now.

ElDeveloper commented 10 years ago

:+1:

teravest commented 10 years ago

This is on webdev now :)

adamrp commented 10 years ago

Thanks!

On Fri, Feb 21, 2014 at 4:22 PM, teravest notifications@github.com wrote:

This is on webdev now :)

Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime_web_app/pull/632#issuecomment-35784374 .

adamrp commented 10 years ago

Minor aesthetic comment: can you change the <td> status rectangle (the thing that's green, red, purple, etc.) to have colspan=2 and align=center?

adamrp commented 10 years ago

metadata checker gets triggered regardless of project and/or project_group, so that should be conditional for AG at this point

adamrp commented 10 years ago

The default value for "Sequencing Status" in the database is NULL, so I think there needs to be an "unknown" (or "N/A" or something to that effect) option in that dropdown

adamrp commented 10 years ago

Many of the fields have a "Current: " next to them (I assume so that you can tell if you're changing something before you hit submit?), but others don't.

adamrp commented 10 years ago

Barcode 000007185 is office succession, but the checkbox or emailing says "Send kit owner an email" I might be mistaken, but I don't think that study has kits

adamrp commented 10 years ago

Not sure, but I think only projects in the AG project group currently work (do not have access to SQL developer atm)

teravest commented 10 years ago

I forgot the code to look up the barcode itself currently uses a stored procedure that looks in an american gut table. So this will only work with American Gut right now. I am going separate that into two stored procedures and only call the american gut one if it is an american gut barcode :)

teravest commented 10 years ago

Updates are deployed on Webdev Here is a list of barcodes to test with. One from each project 000000001 000006136 000005074 000007185 000005038 000007869 000010307 000011423 000006020

teravest commented 10 years ago

Updated webdev again this morning.

ElDeveloper commented 10 years ago

@teravest not sure if this has to be part of this pull request, but I looked for barcode 000004595 and sent an e-mail, the e-mail came in as:

   In order to help you in adding these details, the side of the sample tube 000004595 reads:
      sample date: [Field('sample_date', ''), Field('sample_date', '')] 
      sample time: [Field('sample_time', ''), Field('sample_time', '')]

I'm looking at the code now.

ElDeveloper commented 10 years ago

screen shot 2014-03-06 at 2 28 36 pm

ElDeveloper commented 10 years ago

Great stuff @teravest

adamrp commented 10 years ago

@teravest, is this ready to be merged?

teravest commented 10 years ago

no, I have some things to change and its gonna need another review and more testing :(

On Wed, Mar 26, 2014 at 11:07 AM, adamrp notifications@github.com wrote:

@teravest https://github.com/teravest, is this ready to be merged?

Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime_web_app/pull/632#issuecomment-38710888 .

ElDeveloper commented 10 years ago

Fair enough, thanks @teravest