search

qiime / qiime_web_app

QIIME, EMP and American Gut Web Application
www.microbio.me/qiime
9 stars 10 forks source link

Hide exception from users when they try to register twice #682

Closed teravest closed 10 years ago

teravest commented 10 years ago

This happens when the user hits the back button and then register user a second time.

teravest commented 10 years ago

I also fixed another bug, format_submit_to_fusebox_string was not being imported.

teravest commented 10 years ago

Addresses part 3 of #681

ElDeveloper commented 10 years ago

Code looks good! I just deployed this to webdev, do you happen to have a few test barcodes handy?

teravest commented 10 years ago

I'll email you guys a list of kit_id/passwords to test with.

On Mon, Apr 21, 2014 at 9:42 AM, Yoshiki Vázquez Baeza < notifications@github.com> wrote:

Code looks good! I just deployed this to webdev, do you happen to have a few test barcodes handy?

— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime_web_app/pull/682#issuecomment-40945207 .

ElDeveloper commented 10 years ago

Got them, thanks!

Yoshiki.

On Apr 21, 2014, at 9:43 AM, teravest notifications@github.com wrote:

I'll email you guys a list of kit_id/passwords to test with.

On Mon, Apr 21, 2014 at 9:42 AM, Yoshiki Vázquez Baeza < notifications@github.com> wrote:

Code looks good! I just deployed this to webdev, do you happen to have a few test barcodes handy?

— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime_web_app/pull/682#issuecomment-40945207 .

— Reply to this email directly or view it on GitHub.

teravest commented 10 years ago

I addressed the comments. If this looks good it would be nice to deploy today so no one sees the exception.

ElDeveloper commented 10 years ago

@teravest, thanks for making the changes, this looks good. @adamrp would you mind taking a look and merging if you think it's all good now?

ElDeveloper commented 10 years ago

Also I got a second e-mail after reregistering, which is IMHO a feature not a bug, just wanted to make sure this was documented somewhere.

adamrp commented 10 years ago

Added a couple comments -- looks good otherwise. If this is a page we want to reuse for other DB errors, we should be prepared to modify this page to display an arbitrary message rather than hard-coding the bit about back buttons and accidental duplicate-registrations.

teravest commented 10 years ago

I wrote a new page so that we could reuse it for other situations. Can I set up the page to take hidden form items with psp.redirect?

adamrp commented 10 years ago

Yeah, that's basically what I was thinking, not sure if there are better ideas out there.

On Mon, Apr 21, 2014 at 7:17 PM, teravest notifications@github.com wrote:

I wrote a new page so that we could reuse it for other situations. Can I set up the page to take hidden form items with psp.redirect?

— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime_web_app/pull/682#issuecomment-40994558 .

teravest commented 10 years ago

most recent changes are on webdev

teravest commented 10 years ago

@adamrp look good?