search

qiime / qiime_web_app

QIIME, EMP and American Gut Web Application
www.microbio.me/qiime
9 stars 10 forks source link

[WIP] New ebi submit [WIP] #704

Open adamrp opened 10 years ago

adamrp commented 10 years ago

Almost there, but I thought I'd get this in now so that people can begin reviewing, it's kind of big.

Needs:

adamrp commented 10 years ago

Thanks for the review @wasade, I'll implement these changes soon!

ElDeveloper commented 10 years ago

I like how the code is looking!

I would like to hear what your plans are for testing the main EBI object, as it stands right now, I can see that it's acting a lot as a data formatter, hence I would be inclined to leave the submission of files to a separate object, would be curious to hear what others think.

wasade commented 10 years ago

Agree, submit should be external On Jun 9, 2014 1:21 PM, "Yoshiki Vázquez Baeza" notifications@github.com wrote:

I like how the code is looking!

I would like to hear what your plans are for testing the main EBI object, as it stands right now, I can see that it's acting a lot as a data formatter, hence I would be inclined to leave the submission of files to a separate object, would be curious to hear what others think.

— Reply to this email directly or view it on GitHub https://github.com/qiime/qiime_web_app/pull/704#issuecomment-45532309.