search

qiime2 / Keemei

Validate tabular bioinformatics file formats in Google Sheets
https://keemei.qiime2.org
BSD 3-Clause "New" or "Revised" License
5 stars 20 forks source link

HTML service setSandboxMode deprecated #76

Closed corburn closed 7 years ago

corburn commented 7 years ago

setSandboxMode is probably not required here:

https://github.com/biocore/Keemei/blob/7a9929cb03fcfeb4cac5f62b0e97717da16a5bc4/src/App.gs#L40

https://developers.google.com/apps-script/ July 6, 2016 NATIVE sandbox mode is now shut down. All scripts default to IFRAME mode, regardless of which mode, if any, is specified.

jairideout commented 7 years ago

Thanks @corburn! Would you be interested in submitting a PR to remove the line? (I'm excited to have a new set of eyes on the source code too!)

corburn commented 7 years ago

Hello @jairideout,

Yes, I will test this out tonight and submit a PR if it works.

jairideout commented 7 years ago

Great, thanks!