search

qiime2 / Keemei

Validate tabular bioinformatics file formats in Google Sheets
https://keemei.qiime2.org
BSD 3-Clause "New" or "Revised" License
5 stars 20 forks source link

same barcode with different casing will be consider different #81

Open antgonza opened 7 years ago

antgonza commented 7 years ago

Current Behavior AAAA and AaAA are different in the validator, and IMOO they should not

jairideout commented 7 years ago

Thanks @antgonza! What does validate_mapping_file.py do in this case?

antgonza commented 7 years ago

Not sure. @walterst, do you know?

walterst commented 7 years ago

Hmm, I don't think they should be considered differently, the barcodes are forced into upper() when they are put into a list to be tested: https://github.com/biocore/qiime/blob/master/qiime/check_id_map.py#L577 https://github.com/biocore/qiime/blob/master/qiime/check_id_map.py#L621 https://github.com/biocore/qiime/blob/master/qiime/check_id_map.py#L707

jairideout commented 7 years ago

Thanks for confirming @walterst! I agree that Keemei's validator should get updated to find duplicate barcodes in a case-insensitive manner.