search

qiime2 / docs

https://docs.qiime2.org
BSD 3-Clause "New" or "Revised" License
21 stars 58 forks source link

maint: native installation instructions for apple silicon users #545

Closed thermokarst closed 1 year ago

thermokarst commented 1 year ago

Updates the native installation docs to not disregard M2 apple silicon users. Also updates the WSL instructions to unify the usage of the WSL acronym from elsewhere in the docs.

image

image

thermokarst commented 1 year ago

Hey @lizgehret & @ebolyen - I updated this PR with some additional a11y edits and squashed the commits down. I'm happy to make any other edits (or close this PR in favor of something else, I recognize this was an unsolicited PR, I don't want to make more work for y'all!), just let me know. Thanks!

lizgehret commented 1 year ago

Hi @thermokarst these edits seem fine, we'll go ahead and merge this. Thanks!

thermokarst commented 1 year ago

Thanks @lizgehret. I noticed you changed the PR title - I just want to draw your attention to the fact that this PR wasn't just about updating the Apple Silicon instructions, it generally updated several of the native installation hints (just in case you missed that in your review). Thanks!

thermokarst commented 1 year ago

I updated the changelog with these edits, BTW. Thanks!

lizgehret commented 1 year ago

Yep! I did notice that, thanks @thermokarst - 'hints' wasn't a super clear motivation for what this PR is doing. This title made more sense to me for the primary changes that were made (especially in relation to the PR that this was based off of). Thanks for updating the changelog!