search

qiime2 / provenance-lib

QIIME 2 Provenance Replay Tools
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

BUG: reproducibility-supplement renders temp filepaths in scripts #100

Open ChrisKeefe opened 2 years ago

ChrisKeefe commented 2 years ago

When dumping metadata to the reproducibility supplement, the supplement scripts should reference the relative file path of that dumped (and zipped) metadata.

Instead, it references the temporary location where the file was stored pre-compression.

gregcaporaso commented 1 year ago

I just ran into this today. Here's an example, just so we have it recorded here:

# The following command may have received additional metadata .tsv files. To
# confirm you have covered your metadata needs adequately, review the
# original metadata, saved at '/var/folders/jp/_7s6840d2gdf_gkg1291p7x00000g
# n/T/tmpucauzn2j/recorded_metadata/taxa_barplot_0'

The command I ran was:

replay supplement --i-in-fp analysis-results --o-out-fp supplement.zip

So given the output zip file name, the path in this case should be supplement/recorded_metadata/taxa_barplot_0.

gregcaporaso commented 1 year ago

@wasimsandhu is going to take this one, as part of a summer class project. Welcome to the project @wasimsandhu!

gregcaporaso commented 1 year ago

@wasimsandhu reached out and said he's not going to be able to work on this after all, so this one is unassigned again.

Thanks again for letting me know @wasimsandhu - reach out if you want to get involved in the future!