qiime2 / provenance-lib

QIIME 2 Provenance Replay Tools
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Think about ProvDAG equality criteria #36

Open ChrisKeefe opened 2 years ago

ChrisKeefe commented 2 years ago

From inline notes

ProvDAG equality checks are currently based on class identity and graph isomorphism.

Is this a reasonable way to define ProvDAG equality? It doesn't take into account the equality of some ProvDAG attributes, but leans on DiGraph isomorphism.

Questions

Are two isomorphic ProvDAGs unequal if one was created without checksum validation?

How about if one has a checksum diff because it's been tinkered with?

If in the future we have a method that produces non-identical results from two identical DiGraphs based on _parsed_artifact_uuids, are those ProvDAGs still equal?