search

qiime2 / q2-composition

BSD 3-Clause "New" or "Revised" License
5 stars 28 forks source link

MAINT: disallow numerical md cols for ref level param #107

Closed lizgehret closed 1 year ago

lizgehret commented 1 year ago

This PR addresses the following:

  1. qiime composition tabulate viz improvements:

    • Each tab now contains the data slice name and short descriptions for LFC and W-Scores.
    • Columns used to calculate the intercept are included at the top of each slice's table.

  2. qiime composition ancombc improvements:

    • Numerical metadata columns disallowed for the reference_level parameter, and associated unit tests.

  3. Citations added for ancombc and modified/hooked up for ancom.

  4. Some misc. re-formatting/syntax updates for plugin-wide consistency.

  5. New dataloaf.qza artifact that reflects the ANCOM-BC 3.16 release output.

lizgehret commented 1 year ago

Here's what the added citations look like: Screen Shot 2023-02-21 at 9 43 19 AM

lizgehret commented 1 year ago

And here's what the slice/name description additions look like:

Screen Shot 2023-02-21 at 11 10 57 AM Screen Shot 2023-02-21 at 11 11 09 AM Screen Shot 2023-02-21 at 11 11 18 AM

Intercept columns haven't been added yet, that's the last thing on the list for this PR.

lizgehret commented 1 year ago

Final viz preview with intercept columns added:

Screen Shot 2023-02-21 at 3 19 13 PM

lizgehret commented 1 year ago

Okay @ebolyen I think this one is finally ready for review!