BUG: single ref level string splitting in tabulate viz

qiime2 / q2-composition

BSD 3-Clause "New" or "Revised" License

5 stars 27 forks source link

BUG: single ref level string splitting in tabulate viz #116

Closed lizgehret closed 1 year ago

lizgehret commented 1 year ago

Fixes #115

This PR adds the following (in addition to the bug fix above):

Gets default reference_level value (if none are included by the user) based on dummy coding for use in tabulate viz.
Maintains types specified in the input metadata via type directive, so any columns with numeric values that are specified as categorical aren't converted to numeric when passed into R.
Adds testing for tabulate vis, and the functionality above.

lizgehret commented 1 year ago

This bug is a good motivator to get unit tests added for tabulate - I'm including these in this PR since they do accompany this bug fix.

lizgehret commented 1 year ago

Okay so there's one remaining TODO on this PR @Oddant1 (see commit #dea877d) but I've left that alone for now because I'm not sure how to handle that in R (type conversion is really dumb).

Oddant1 commented 1 year ago

I'm not sure how to handle that in R (type conversion is really dumb).

R typing has been the single largest pain point for me in inf-511

lizgehret commented 1 year ago

@Oddant1 do you have any final review comments, or do you think this is g2g?

Oddant1 commented 1 year ago

I think it looks good