search

qiime2 / q2-composition

BSD 3-Clause "New" or "Revised" License
5 stars 28 forks source link

BUG: Fixes URL space issue in DA plots #117

Closed cherman2 closed 1 year ago

cherman2 commented 1 year ago

This PR fixes the issue with URLs breaking if there is a space in the metadata value. This will address issue https://github.com/qiime2/q2-composition/issues/114

Issue Details: The URL's for the subplots have to be double encoded because of q2-view's decoding. The first encoding encoded spaces as + and the second encoding encoded spaces as %20 which are both valid encodings of space. Because of this incompatibility the second encoding was encoding the + as %2B because it recognized it as a valid + and not an encoding of space. Changing the first encoding so that it encoded spaces as %20 to match the second encoding solved this issue.

Oddant1 commented 1 year ago

Is there a test for this? If not, should we add one?